Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st1002: implementation of Range Image Local Set #455

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented Feb 7, 2023

Motivation and Context

Implements ST 1002 Range Image Local Set.

Resolves #167.

Relates #171. The full implementation of that in ST 0601 is more complicated than this implementation.

Description

This required ST 1202 transformations, which in turn required ST 1010 SDCC.

Includes usual javadoc, unit tests and a generator example.

How Has This Been Tested?

Unit tests.

I don't have any real data.

The generator output works in the viewer app.

I did check it with CMITT, but it looks like I'm hitting bugs in that (at least, the problem is reproduced by the CMITT developers), so it isn't clear how good the actual data is.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bradh bradh force-pushed the st1002merge branch 2 times, most recently from 6e91977 to 61c04a1 Compare February 7, 2023 23:43
This required ST 1202 transformations, which in turn required ST 1010 SDCC.

Includes usual javadoc, unit tests and a generator example.
@bradh bradh marked this pull request as ready for review February 8, 2023 08:12
@bradh bradh requested a review from wlfgang February 8, 2023 08:12
Copy link
Contributor

@wlfgang wlfgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Apologies for the delay!

@wlfgang wlfgang merged commit d05758b into WestRidgeSystems:2.x Apr 11, 2023
@bradh bradh deleted the st1002merge branch April 11, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants