Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added to wmn-data.json with SimplePlanes #890

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

SlopeSlayer910
Copy link
Contributor

Added entry for SimplePlanes.com
{
"name" : "SimplePlanes",
"uri_check" : "https://www.simpleplanes.com/u/{account}",
"e_code" : 200,
"m_code" : 302,
"known" : ["realSavageMan", "Jundroo", "john"],
"cat" : "gaming"
},
Entry is missing its e_string and m_string as I do not yet know how to discern those

Added entry for SimplePlanes.com
{
        "name" : "SimplePlanes",
        "uri_check" : "https://www.simpleplanes.com/u/{account}",
        "e_code" : 200,
        "m_code" : 302,
        "known" : ["realSavageMan", "Jundroo", "john"],
        "cat" : "gaming"
       },
@WebBreacher
Copy link
Owner

Hey @SlopeSlayer910. Thanks for the submission. Finding the e_string and m_string are done by looking in the source code of the response from the server. The /~https://github.com/WebBreacher/WhatsMyName/blob/main/CONTRIBUTING.md file has a little bit about this.

@SlopeSlayer910
Copy link
Contributor Author

@WebBreacher, Added the suggested e and m strings to the PR, should pass now

@SlopeSlayer910
Copy link
Contributor Author

@WebBreacher, fixed issues with local files not pushing and committing changes. Should all validate now

@WebBreacher WebBreacher merged commit 70e1c8e into WebBreacher:main Oct 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants