Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this PR is the
SampleTest
implementation, which was basically copied with some fixes from thequickcheck
tester. There are several notable changes:Debug
impl on tuples means there's no need to define a separateshrink
function for eachTestable
. This simplifies the implementations and associated macro.quickcheck
)Aside from that, the
#[sample_test]
macro gets much simpler as we no longer need to deriveArbitrary
newtypes for each sampler. This also makes it more ergonomic: you can now define values directly and use function calls instead of the priorlazy_static
requirement.The only downside is when using
once_cell::sync::Lazy
orlazy_static
, you need to call.clone()
(as we expect the sampler by-value and these constructs return aDeref
). I don't think this is a major problem as the function-call or direct-value use cases are probably the common path.