Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing API version and kind for volumeClaimTemplates #1107

Merged
merged 2 commits into from
Jul 5, 2024
Merged

add missing API version and kind for volumeClaimTemplates #1107

merged 2 commits into from
Jul 5, 2024

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Jul 4, 2024

address #1092

@Haleygo Haleygo requested review from Amper and zekker6 as code owners July 4, 2024 05:24
@github-actions github-actions bot added agent vmagent helm chart related issue cluster vmcluster helm chart related issue single VictoriaMetrics Single node helm chart related issue anomaly vmanomaly logs-single labels Jul 4, 2024
AndrewChubatiuk
AndrewChubatiuk previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@AndrewChubatiuk AndrewChubatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haleygo Haleygo merged commit 8ff58b9 into master Jul 5, 2024
45 checks passed
@Haleygo Haleygo deleted the gh-1092 branch July 5, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekker6 zekker6 zekker6 approved these changes

@AndrewChubatiuk AndrewChubatiuk AndrewChubatiuk left review comments

@Amper Amper Awaiting requested review from Amper

Assignees
No one assigned
Labels
agent vmagent helm chart related issue anomaly vmanomaly cluster vmcluster helm chart related issue logs-single single VictoriaMetrics Single node helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haleygo @zekker6 @AndrewChubatiuk