fix: correct the sr1cs constraints #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds --wtns, which indicates the output directory for the witness files. If not given, no witness file is generated. The witness files are called `first-witness.wtns` and `second-witness.wtns`.
We need to set the Racket environment variable, which is cumbersome. Having a main script would be more convenient for users. Also adjust the README accordingly
When built locally, Picus often fails to run due to the mismatch of the compiled files in the newer, local Racket version, and the older, image-based Racket version. This commit fixes the issue.
CoCoA wasn't successfully compiled on arm64 for some reasons. See /~https://github.com/Veridise/Picus/actions/runs/6483965862/job/17606717211#step:4:15460. So we disable arm64 target for now.
This should help making the Docker image a bit smaller.
In the weak correctness (default mode), output signals must be different, so diffing the output signals are informative enough. But in the strong corectness (when --strong is given), output signals could be identical. It would be more helpful to diff the internal signals to see what are different. This commit adds diffing for the internal variables.
* Setup pre-release files * Setup release files --------- Co-authored-by: sorawee <sorawee@users.noreply.github.com> Co-authored-by: shankarapailoor <shankarapailoor@users.noreply.github.com>
Prior this commit, yvec will reuse input variables from xvec which is sound because we assume that they are equal anyway. However, this reusing adds complexity to Picus. This commit removes the reusing, simplifying the codebase. The removal should also not affect performance, since SMT solvers are very good at dealing with equalities. This also allows modular verification to be programmed more straightforwardly.
…22) Previously, we added them during a constraint optimization pass as a part of the AST traversal. This is not ideal for many reasons. First, we only want to include the definitons once, but the AST traversal opens an opportunity to accidentally include them more than once (e.g. if we happen to have a rcmds as a subnode of another node). Second, it meant that we needed the pdef? parameter so that on alternative constraints, the prime definitions are omitted. The refactoring simply put the definition inclusion at the top-level, simplifying the optimization pass.
* chore: clean up indentation * logging: log inferred known vars
See the changelog for details
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.