Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VaapiVideoEncoder to AcceleratedVideoEncoder #1007

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ImUrX
Copy link

@ImUrX ImUrX commented Dec 14, 2024

From what I checked VaapiVideoEncoder doesn't seem to work when checking chrome://gpu, it keeps saying Video Encode: Software only. Hardware acceleration disabled. But if you use AcceleratedVideoEncoder it does say Video Encode: Hardware accelerated.

I tried verifying if this actually does something, and when using nvtop it does show activity on the ENC section when using AcceleratedVideoEncoder but it doesn't when using VaapiVideoEncoder.

For debugging purposes I leave my output of vainfo:

$ vainfo 
Trying display: wayland
libva info: VA-API version 1.22.0
libva info: Trying to open /run/opengl-driver/lib/dri/radeonsi_drv_video.so
libva info: Found init function __vaDriverInit_1_22
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.22 (libva 2.22.0)
vainfo: Driver version: Mesa Gallium driver 24.2.6 for AMD Radeon RX 7900 XTX (radeonsi, navi31, LLVM 18.1.8, DRM 3.59, 6.11.10-xanmod1)
vainfo: Supported profile and entrypoints
      VAProfileH264ConstrainedBaseline: VAEntrypointVLD
      VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice
      VAProfileH264Main               : VAEntrypointVLD
      VAProfileH264Main               : VAEntrypointEncSlice
      VAProfileH264High               : VAEntrypointVLD
      VAProfileH264High               : VAEntrypointEncSlice
      VAProfileHEVCMain               : VAEntrypointVLD
      VAProfileHEVCMain               : VAEntrypointEncSlice
      VAProfileHEVCMain10             : VAEntrypointVLD
      VAProfileHEVCMain10             : VAEntrypointEncSlice
      VAProfileJPEGBaseline           : VAEntrypointVLD
      VAProfileVP9Profile0            : VAEntrypointVLD
      VAProfileVP9Profile2            : VAEntrypointVLD
      VAProfileAV1Profile0            : VAEntrypointVLD
      VAProfileAV1Profile0            : VAEntrypointEncSlice
      VAProfileNone                   : VAEntrypointVideoProc

@ImUrX
Copy link
Author

ImUrX commented Dec 14, 2024

@ImUrX
Copy link
Author

ImUrX commented Dec 14, 2024

I want to also specify that I wasn't able to make --enable-features work on Vesktop, I'm not even sure that they are passed to Chromium.
But the feature I suggest to use does work when using Discord Web on Chromium

@Covkie
Copy link
Collaborator

Covkie commented Dec 15, 2024

The 'Vaapi' -> 'Accelerated' flag change is for a later version of chromium than electron33 currently runs. This change will need to be made when we bump to 34 or later.

@Covkie Covkie closed this Dec 15, 2024
@Vendicated Vendicated reopened this Dec 15, 2024
@Vendicated Vendicated marked this pull request as draft December 15, 2024 02:04
@danielfrrrr
Copy link

Although the VaapiVideoDecoder and VaapiVideoDecodeLinuxGL options are enabled by default, they have also been renamed: AcceleratedVideoDecoder and AcceleratedVideoDecodeLinuxGL.

See: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/gpu/vaapi.md#vaapi-on-linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants