Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interactive config wizard #3964

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update interactive config wizard #3964

merged 1 commit into from
Dec 12, 2024

Conversation

scudette
Copy link
Contributor

Use /~https://github.com/charmbracelet/huh instead of the deprecated github.com/AlecAivazis/survey.

Refactor the questions to make the process more streamlined.

Use /~https://github.com/charmbracelet/huh instead of the deprecated
github.com/AlecAivazis/survey.

Refactor the questions to make the process more streamlined.
@predictiple
Copy link
Contributor

Shouldn't we be masking the passwords?

Screenshot from 2024-12-12 08-10-02

@scudette
Copy link
Contributor Author

I was in two minds about it - if we mask it we might need to ask twice and compare. OTOH the plain text password is not stored and only displayed on the screen (and huh wipes the screen properly).

Seeing this is a config generator it is probable that the password is already written down (it is the initial password anyway). Also passwords are only used for self signed deployments which are less secure.

So for all these reasons I thought its probably better not to mask the password? Or maybe we can have it typed twice?

@predictiple
Copy link
Contributor

Masking it is a bit silly. Your reasons make sense and personally I prefer it to not be masked or entered twice. So as long as it's not an accidental oversight it's no problem.

@scudette
Copy link
Contributor Author

It is definitely different behavior than the previous code though. Lets add it in without masking now and see what the feedback is

@scudette scudette merged commit 9b65cdf into master Dec 12, 2024
3 checks passed
@scudette scudette deleted the survey branch December 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants