Icons added #354
Closed
Icons added #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
VaibhavArora314
requested changes
Jul 3, 2024
akbatra567
reviewed
Jul 3, 2024
| @@ -16,6 +16,7 @@ import React from "react"; | |||
| import Loader from "./components/Loader"; | |||
| import ContactUs from "./pages/ContactUs"; | |||
| import About from "./pages/About"; | |||
| import Rateus from "./pages/Rateus"; | |||
There was a problem hiding this comment.
component name is RateUs, can we keep it consistent across the code? also could you change the file name from Rateus to RateUs as well?
|
Yeah okkk @VaibhavArora314 @akbatra567 |
akbatra567
reviewed
Jul 3, 2024
| import { loggedInState } from '../store/atoms/auth'; | ||
| import { CgProfile } from 'react-icons/cg'; | ||
| import { BsFilePost } from 'react-icons/bs'; | ||
| import { FaHome,FaRegCopyright } from 'react-icons/fa'; |
There was a problem hiding this comment.
Story was related to Navbar Icons, why we need changes in Footer.tsx ?
If scope is changes, could you update in Issue ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Project Admin
I Added Icons to Navbar - Solved #311
Kindly Please go through this PR @VaibhavArora314