Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: ビルダーパターンの締めの"exec"/"execute"を"perform"に #911

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 29, 2024

内容

BREAKING-CHANGE: Java APIのメソッド名変更

関連 Issue

Refs: #388, #908

その他

@qryxip qryxip requested a review from Hiroshiba December 29, 2024 07:20
@qryxip qryxip force-pushed the feat-rename-exec-execute-to-perform branch from 1e985cd to fdc875a Compare December 29, 2024 07:26
@qryxip qryxip changed the title feat!: ビルダースタイルの締めの"exec"/"execute"を"perform"に feat!: ビルダーパターンの締めの"exec"/"execute"を"perform"に Dec 29, 2024
@qryxip qryxip marked this pull request as draft December 29, 2024 07:36
BREAKING-CHANGE: Java APIのメソッド名変更
@qryxip qryxip force-pushed the feat-rename-exec-execute-to-perform branch from fdc875a to a8cbb88 Compare December 29, 2024 07:42
@qryxip qryxip marked this pull request as ready for review December 29, 2024 07:42
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

コンフリクトしてるかもです!

@qryxip qryxip force-pushed the feat-rename-exec-execute-to-perform branch from 79f243a to 4325631 Compare January 17, 2025 14:39
@qryxip qryxip merged commit a5b8d84 into VOICEVOX:main Jan 17, 2025
30 checks passed
@qryxip qryxip deleted the feat-rename-exec-execute-to-perform branch January 17, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants