Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rust APIのビルダー構造体を#[must_use]にする #910

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 27, 2024

内容

Rust APIを使う次のようなコードに対して警告が出るようにする。

Onnxruntime::load_once();

Image

関連 Issue

Refs: #388, #908

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ちょっとビルダー周り考えるのに使う時間リソースは後回しにしたほうが良さそうな気がしています。
まだ結構かかりそうだけど、考えるのは今では無いかなーと。

@qryxip qryxip merged commit 0248b7a into VOICEVOX:main Dec 27, 2024
29 checks passed
@qryxip qryxip deleted the feat-make-rust-api-builder-structs-must-use branch December 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants