refactor: Rust APIのSynthesizerのメソッドをビルダースタイルに
#907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
force-pushed
the
refactor-make-rust-api-synthesizer-methods-builds
branch
from
2f2cd05 to
ec9ac71
Compare
qryxip
added a commit
to qryxip/voicevox_core
that referenced
this pull request
Dec 29, 2024
qryxip
added a commit
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
api-design.mdでの方針に従い、Rust APIの表層から
{Initialize,Synthesis,Tts}Optionsを消してビルダースタイルにする。voicevox_core/docs/guide/dev/api-design.md
Line 13 in babb3b7
関連 Issue
Refs: #388
その他
帰省の途中、航空機内で実装しました。これが丁度よさそうだったので…