Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics and Prometheus support #24

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Add metrics and Prometheus support #24

merged 1 commit into from
Jul 23, 2024

Conversation

b-rowan
Copy link
Contributor

@b-rowan b-rowan commented Jul 22, 2024

Adds some very basic metrics (registered users and device count), along with the default metrics provided by OpenTelemetry and its FastAPI integration. We may want to look at making the different exporters into feature flags.

This should provide a very basic starting point to start adding better telemetry, along with spans and logging.

@b-rowan
Copy link
Contributor Author

b-rowan commented Jul 22, 2024

Closes #26.

@b-rowan b-rowan linked an issue Jul 22, 2024 that may be closed by this pull request
Copy link
Collaborator

@tsagadar tsagadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked with my local Prometheus installation. Great to have this in place.

@b-rowan b-rowan merged commit 15f61e4 into master Jul 23, 2024
@b-rowan b-rowan deleted the dev_metrics branch July 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics
2 participants