Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use uv for package management #31

Conversation

MitchellAcoustics
Copy link
Collaborator

Per my reopening of #24 , I have adjusted to use uv rather than Rye. uv has now integrated a lot of the features from Rye (they now have the same developers) and uv is considered the stable option.

The pyproject.toml has been updated, Rye's requirements.lock and requirements-dev.lock are replaced with uv.lock, the Github test action is updated to use uv both for its own speed and for compatibility, and I added some info to the README. Hopefully it's easy to adjust to using uv - it should already be installed for you if you have Rye.

Should speed up the readthedocs build. I can't test this configuration since I don't have access to the readthedocs account though.
Copy link
Collaborator

@Nitnelav Nitnelav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks good to me ! Thanks for that

@Nitnelav Nitnelav merged commit 92a1a00 into Universite-Gustave-Eiffel:main Oct 30, 2024
1 check passed
Nitnelav added a commit that referenced this pull request Oct 30, 2024
@MitchellAcoustics
Copy link
Collaborator Author

Yeah, that was the one thing I couldn't test! I directly used the code from readthedocs documentation, but I was a bit sceptical of it, seems more complex than needed.

If you struggle with getting it to work, I can test out the configuration with Soundscapy and figure out what works. I need to switch it from Rye anyway.

@Nitnelav
Copy link
Collaborator

Yes, I'll check a bit later today. I'll try to give you access to readthedocs too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants