Bugfix - missing HF token to retrieve model information #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArzelaAscoIi
changed the title
|
Hi @nreimers ! :) Could you help me and have a look at this PR and check if this could be merged ? I think this is currently blocking users to use private HF models. 🤔 Let me know if I should change something. :) |
|
Sorry for taking so long and thanks for pushing this back to my attention. I will try to merge it soon. |
|
No worries! Thank you for taking care of this! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SentenceTransformerclass supports theuse_auth_tokenparameter, but thesnapshot_downloadfunction does not use the huggingface token to retrieve the model information before downloading the model. Therefore, the huggingface api returns a 404 if you want to use private models (_api.model_info).