Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-9195] Add podAnnotations to tyk-gateway chart #58

Merged
merged 10 commits into from
Jul 5, 2023

Conversation

buraksekili
Copy link
Collaborator

@buraksekili buraksekili commented Jun 19, 2023

Description

This PR adds podAnnotations, which allows defining annotations for currently available component charts pods; Tyk Gateway, Tyk Dashboard, Tyk Bootstrap, and Tyk Pump.

Related Issue

https://tyktech.atlassian.net/browse/TT-9195

Resolves #51

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ons to Tyk Gateway pod

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@buraksekili buraksekili changed the title Add podAnnotations to tyk-gateway chart [TT-9195] Add podAnnotations to tyk-gateway chart Jun 20, 2023
@buraksekili buraksekili marked this pull request as ready for review June 20, 2023 07:22
@buraksekili buraksekili requested a review from a team as a code owner June 20, 2023 07:22
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team June 20, 2023 07:22
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
…gies/tyk-charts into feat/TT-9195/pod-annotations
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@singhpr singhpr merged commit d326261 into main Jul 5, 2023
@singhpr singhpr deleted the feat/TT-9195/pod-annotations branch July 5, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to define pod annotations in tyk-gateway Helm Chart
3 participants