Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(socketio/ns): improve connect process #129

Merged
merged 2 commits into from
Oct 25, 2023
Merged

feat(socketio/ns): improve connect process #129

merged 2 commits into from
Oct 25, 2023

Conversation

Totodore
Copy link
Owner

@Totodore Totodore commented Oct 25, 2023 •
edited
Loading

Improve the connect process by moving it to the connect fn in the ns module

Thanks to that :

  • The user handler is called only when the connect response is successfully sent trough the channel
  • If the socket channel returns an error the socket connection is instantly closed

@Totodore Totodore merged commit d2f5220 into main Oct 25, 2023
8 checks passed
@Totodore Totodore deleted the ft-improve-connect-process branch October 25, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Totodore