chore(ci/e2e): fix polling ping timeout test (#436)

In case of http polling heartbeat timeout, engine.io might send a close packet to an existing polling connection before closing. Fix the test for this case.
Totodore · Jan 15, 2025 · a3f48f7 · a3f48f7
1 parent d89e78c
commit a3f48f7
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 188 deletions.
diff --git a/e2e/engineioxide/test-suites/v4.ts b/e2e/engineioxide/test-suites/v4.ts
@@ -389,7 +389,10 @@ describe("Engine.IO protocol", () => {
           `${POLLING_URL}/engine.io/?EIO=4&transport=polling&sid=${sid}`,
         );
 
-        assert.deepStrictEqual(pollResponse.status, 400);
+        assert(
+          pollResponse.status == 400 ||
+            (pollResponse.status == 200 && (await pollResponse.text()) == "1"),
+        );
       });
     });
 

diff --git a/e2e/socketioxide/test-suites/package-lock.json b/e2e/socketioxide/test-suites/package-lock.json
diff --git a/e2e/socketioxide/test-suites/v5-msgpack.ts b/e2e/socketioxide/test-suites/v5-msgpack.ts
@@ -215,7 +215,10 @@ describe("Engine.IO protocol", () => {
           `${POLLING_URL}/socket.io/?EIO=4&transport=polling&sid=${sid}`,
         );
 
-        assert.equal(pollResponse.status, 400);
+        assert(
+          pollResponse.status == 400 ||
+            (pollResponse.status == 200 && (await pollResponse.text()) == "1"),
+        );
       });
     });
 

diff --git a/e2e/socketioxide/test-suites/v5.ts b/e2e/socketioxide/test-suites/v5.ts
@@ -214,7 +214,10 @@ describe("Engine.IO protocol", () => {
           `${POLLING_URL}/socket.io/?EIO=4&transport=polling&sid=${sid}`,
         );
 
-        assert.equal(pollResponse.status, 400);
+        assert(
+          pollResponse.status == 400 ||
+            (pollResponse.status == 200 && (await pollResponse.text()) == "1"),
+        );
       });
     });