Update 2020-03-23-doctrine-entity-typed-properties-with-php74.md

[ThomasLandauer]

With @var Collection<Trainer>, PhpStan gives me (on level 6) - see https://stackoverflow.com/a/64242837/1668200

Property ... with generic interface Doctrine\Common\Collections\Collection does not specify its types: TKey, T

Question/suggestion: Why do you suggest Collection here instead of ArrayCollection? What's the difference?

[TomasVotruba]

Hi, thanks for PR. Beware, PHPStan is not always right. It's still an assumption tool.

How do you know there is int key?

Question/suggestion: Why do you suggest Collection here instead of ArrayCollection? What's the difference?

Because there can be any class of Collection interface. ArrayCollection is just one of them

[ThomasLandauer]

How do you know there is int key?

By dumping it - see the stackoverflow link above. However, I didn't double check Doctrine's source code ;-)

Because there can be any class of Collection interface. ArrayCollection is just one of them

Well, there could be any class, but in fact it is ArrayCollection - isn't it?

Other question: The next thing that's going to happen in this regard is the switch from today's annotations to PHP8's attributes - do you agree? If yes: When people are updating all their entities to PHP7.4's types, is there anything they could do to "prepare" for PHP8?

[TomasVotruba]

I see. Thanks for explaining.
I thought collections are like arrays, so the have int keys by default.

Let's ship it then.

[TomasVotruba]

Well, there could be any class, but in fact it is ArrayCollection - isn't it?

I'd go with SOLID dependency inversion principle here.
But I'm not Doctrine expert, it's just common sense.

[TomasVotruba]

As for prepare for PHP 8, I'd use all the Rector sets from 5.6 to 7.4 and put them in CI.

[ThomasLandauer]

I'd go with SOLID dependency inversion principle here.
But I'm not Doctrine expert, it's just common sense.

Well, symfony/maker-bundle v1.21.1 sees it like you :-) It produces:

/**
 * @return Collection|Bar[]
 */
public function getBars(): Collection
{
    return $this->bars;
}

[TomasVotruba]

😃

That's actually incorrect, as array of Bar[] is not a Collection object.

[TomasVotruba]

To my last comment... I see the type must be technically invalid, so it works in both PHPStorm and PHPStan

Saying that, you might like this @rectorphp rule... 😃
rectorphp/rector#4442

[ThomasLandauer]

Sorry, haven't ever used rector, so I can't say something here ;-)

[TomasVotruba]

No problem. This is the important part:

Basically what your pull-request was about, just automated :)

[TomasVotruba]

[ThomasLandauer]

Great :-)