Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Final2x-core v3.0.0 (ccrestoration) #599

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

Tohrusky
Copy link
Owner

@Tohrusky Tohrusky commented Nov 8, 2024

No description provided.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 27.33333% with 109 lines in your changes missing coverage. Please review.

Project coverage is 23.01%. Comparing base (bfc090d) to head (848aa2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/renderer/src/utils/ModelOptions.ts 0.00% 45 Missing and 1 partial ⚠️
src/renderer/src/views/Final2xSettings.vue 0.00% 35 Missing ⚠️
resources/download-core.js 0.00% 22 Missing ⚠️
src/main/RunCommand.ts 0.00% 2 Missing ⚠️
src/renderer/src/App.vue 0.00% 1 Missing ⚠️
src/renderer/src/components/MyExternalLink.vue 0.00% 1 Missing ⚠️
src/renderer/src/components/MyProgress.vue 0.00% 1 Missing ⚠️
src/renderer/src/utils/getFinal2xconfig.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   27.82%   23.01%   -4.81%     
==========================================
  Files          35       33       -2     
  Lines        2886     2433     -453     
  Branches       90       67      -23     
==========================================
- Hits          803      560     -243     
+ Misses       2063     1853     -210     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tohrusky Tohrusky changed the title dev refactor: use Final2x-core v3.0.0 (ccrestoration) Nov 8, 2024
@Tohrusky Tohrusky merged commit c5c5978 into Tohrusky:main Nov 8, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant