Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Spy Drone Selected By Q-Shortcut #173

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Fix: Spy Drone Selected By Q-Shortcut #173

merged 1 commit into from
Sep 4, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 3, 2021

ZH 1.04

  • The Spy Drone is selected by the Select All (Q) shortcut, even though it completely ignores any orders.

After patch:

  • The Spy Drone is no longer selected by Q, but can still be selected by click or box.

ref: /~https://github.com/xezon/GeneralsGamePatch/issues/40

@commy2 commy2 added the Design Is a matter of game design label Sep 3, 2021
@commy2 commy2 mentioned this pull request Sep 3, 2021
Closed
@xezon xezon self-requested a review September 3, 2021 20:26
xezon
xezon approved these changes Sep 3, 2021
View reviewed changes
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@commy2 commy2 merged commit 4b60183 into main Sep 4, 2021
@commy2 commy2 deleted the fix-spy-drone-q branch September 4, 2021 05:55
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Spy Drone Seleced By Q-Shortcut (#173)
a8cf28a
@xezon xezon changed the title Fix: Spy Drone Seleced By Q-Shortcut Fix: Spy Drone Selected By Q-Shortcut Mar 18, 2023
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @xezon