Update to html-to-react 1.7.0 #7478
Conversation
There was a problem hiding this comment.
The html-to-react version 1.7.0 publishes its TypeScript types, so we should remove our types. The utility types are probably not exposed publicly, but you should be able to re-export them using the declare module syntax. After you remove our types, there may be some library usage issues. I can take this over if you can't or run into issues
pjonsson
force-pushed
the
tsify-moreshallowtools
branch
from
48b874a to
43bea70
Compare
Nice find, I thought those kind of things were usually done in major versions! I have updated the PR. |
pjonsson
force-pushed
the
tsify-moreshallowtools
branch
3 times, most recently
from
037c41f to
d64b304
Compare
Unpin html-to-react now that modules are ESM.
pjonsson
force-pushed
the
tsify-moreshallowtools
branch
from
d64b304 to
24e04e6
Compare
| declare module "html-to-react"; | ||
| declare module "html-to-react/lib/utils"; | ||
| declare module "html-to-react/lib/utils" { | ||
| export * from "html-to-react/types/utils"; |
There was a problem hiding this comment.
@zoran995 was this what you meant with the comment yesterday about re-export of internal types?
I also updated this PR to make the html-to-react imports only import what they use, which I believe helps with tree-shaking.
What this PR does
Unpin html-to-react now that
modules are ESM.
Also TSify MoreShallowTools in the tests.
It's been almost 2 months since I did these changes, so I have forgotten why I put them in the same branch, but I always start a new branch for unrelated changes.
Test me
I believe this is tested by CI?
Checklist
doc/.