Feature/Android: fallback option for player reparenting #497
Conversation
…View among the direct parents
|
@tvanlaerhoven please put this PR on hold for a while until our QA folks test these changes over our apps. Thank you. |
| var parent: ViewParent? = view?.parent | ||
| while (parent != null && parent !is T) { | ||
| parent = parent.parent | ||
| inline fun <reified T : View> ViewGroup.getClosestParentOfType(upward: Boolean = true): T? { |
There was a problem hiding this comment.
@tvanlaerhoven I could move this to some util file, any thoughts? or better keep it here?
There was a problem hiding this comment.
@kot331107 You can move it if you like. It could be useful somewhere else as well indeed.
| ?: (activity.window.decorView.rootView as? ViewGroup) | ||
| ?.getClosestParentOfType(false) |
There was a problem hiding this comment.
would work as a fallback option, so should be safe to merge for current clients I guess. The part to test is PiP reparenting but we set the build flag to false by default as it is experimental
There was a problem hiding this comment.
Just for my understanding: in which case did the upwards search for a suitable root fail?
There was a problem hiding this comment.
in our apps it happens when we switch on the fullscreen mode from inline player. For some reason the React Root view doesn't exist in the direct player's parents in this particular scenario. Also it happens only on the second and any subsequent times. The first attempt it just works fine with the upward search.
kot331107
changed the title
|
converting to draft for now as we see some side effects in our apps we'd like to manage |
Description
Test-plan