Fix Conviva SDK version in Package.json #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current way it is setup fetches the latest pre-release which is unstable, as it crashes due to some unidentified selector. I made the version fetch the exact one just before the pre-release.
This reverts commit eb03f19.
Sometimes with preroll ads we receive the ad break begin event after the access log entry for the ad is sent, which ends up reporting the ad bitrate to the main content. The workaround is to listen to the ad loaded event which seems to be guaranteed to come before we get the access log entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current way it is setup fetches the
latest pre-release which is unstable,
as it crashes due to some unidentified
selector. I made the version fetch
the exact one just before the pre-release.