Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build on 1.10 branch #589

Merged
merged 1 commit into from
Feb 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Bundle/test/src/Entity/Author.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@ final class Author
{
/**
* @Serializer\Expose
*
* @Serializer\Type("string")
*/
private ?string $firstName = null;

/**
* @Serializer\Expose
*
* @Serializer\Type("string")
*/
private ?string $lastName = null;
Expand Down
4 changes: 4 additions & 0 deletions src/Bundle/test/src/Entity/Book.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ class Book implements ResourceInterface, TranslatableInterface

/**
* @Serializer\Expose
*
* @Serializer\Type("integer")
*
* @Serializer\XmlAttribute
*/
private int $id;

/**
* @Serializer\Expose
*
* @Serializer\Type("string")
*/
private ?string $author = null;
Expand All @@ -52,6 +55,7 @@ public function getId()
* @return string
*
* @Serializer\VirtualProperty()
*
* @Serializer\SerializedName("title")
*/
public function getTitle()
Expand Down
6 changes: 6 additions & 0 deletions src/Bundle/test/src/Entity/ComicBook.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,23 @@ class ComicBook implements ResourceInterface
{
/**
* @Serializer\Expose
*
* @Serializer\Type("integer")
*
* @Serializer\XmlAttribute
*/
private int $id;

/**
* @Serializer\Expose
*
* @Serializer\Until("1.1")
*/
private ?Author $author = null;

/**
* @Serializer\Expose
*
* @Serializer\Type("string")
*/
private ?string $title = null;
Expand Down Expand Up @@ -63,6 +67,7 @@ public function setTitle($title)

/**
* @Serializer\VirtualProperty()
*
* @Serializer\Since("1.1")
*/
public function getAuthorFirstName(): ?string
Expand All @@ -72,6 +77,7 @@ public function getAuthorFirstName(): ?string

/**
* @Serializer\VirtualProperty()
*
* @Serializer\Since("1.1")
*/
public function getAuthorLastName(): ?string
Expand Down