Skip to content

Commit

Permalink
Fix coding standard and add conflict explanation
Browse files Browse the repository at this point in the history
  • Loading branch information
loic425 committed Sep 4, 2024
1 parent 8e0ef86 commit ca21c70
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 15 deletions.
5 changes: 5 additions & 0 deletions CONFLICTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@

This document explains why certain conflicts were added to `composer.json` and
references related issues.

- `willdurand/hateoas-bundle: ^2.6`

This version allows Symfony 7 but does not support the "annotation_reader" service removal.
@see /~https://github.com/willdurand/BazingaHateoasBundle/issues/108
2 changes: 0 additions & 2 deletions src/Bundle/AbstractResourceBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ protected function getDoctrineMappingDirectory(): string

/**
* Return the entity namespace.
*
* @return string
*/
protected function getModelNamespace(): ?string
{
Expand Down
3 changes: 0 additions & 3 deletions src/Bundle/Form/EventSubscriber/AddCodeFormSubscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ final class AddCodeFormSubscriber implements EventSubscriberInterface

private array $options;

/**
* @param string $type
*/
public function __construct(?string $type = null, array $options = [])
{
$this->type = $type ?? TextType::class;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

/**
* @template T of ResourceInterface
*
* @extends ObjectRepository<T>
*/
interface RepositoryInterface extends ObjectRepository
Expand Down
3 changes: 0 additions & 3 deletions src/Component/src/Metadata/MetadataInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ public function getPluralName(): string;

public function getDriver(): string|false;

/**
* @return ?string
*/
public function getTemplatesNamespace(): ?string;

/**
Expand Down
3 changes: 0 additions & 3 deletions src/Component/src/Model/ToggleableInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ interface ToggleableInterface
*/
public function isEnabled();

/**
* @param bool $enabled
*/
public function setEnabled(?bool $enabled): void;

public function enable(): void;
Expand Down
3 changes: 0 additions & 3 deletions src/Component/src/Model/ToggleableTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ public function isEnabled(): bool
return $this->enabled;
}

/**
* @param bool $enabled
*/
public function setEnabled(?bool $enabled): void
{
$this->enabled = (bool) $enabled;
Expand Down

0 comments on commit ca21c70

Please sign in to comment.