Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

Add missing author block #34

Merged
merged 3 commits into from
Jul 26, 2018
Merged

Add missing author block #34

merged 3 commits into from
Jul 26, 2018

Conversation

bartoszpietrzak1994
Copy link
Contributor

@bartoszpietrzak1994 bartoszpietrzak1994 commented Jul 26, 2018 •
edited
Loading

Fixes #29

Zales0123
Zales0123 reviewed Jul 26, 2018
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is doing a lot more than just adding a missing author block 😄 💃

composer.json
"sylius-labs/coding-standard": "^2.0"
},
"minimum-stability": "dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it?

Copy link
Contributor Author

@bartoszpietrzak1994 bartoszpietrzak1994 Jul 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we provide Sylius in version ~1.3.0, which basically means dev-master for now, minimum-stability: dev is needed

@bartoszpietrzak1994 bartoszpietrzak1994 force-pushed the add-missing-author-block branch from bf8c7b2 to c2dff9a Compare July 26, 2018 09:42
@Zales0123 Zales0123 merged commit e561695 into Sylius:master Jul 26, 2018
@Zales0123
Copy link
Member

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartoszpietrzak1994 @Zales0123