-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import ABC from collections.abc for py 3.10 compatibility #5007
Conversation
Looks like the CI is not happy as this change breaks the platform functionality and both py27 + py36 CI builds in many ways. |
9874c7d
to
2718f45
Compare
This was due to a typo where Mutableset has to be MutableSet (Capital S in Set). I have fixed it now. |
The lint error doesn't make sense since the module name is moves and not Moves with capital M.
|
We just reformatted the code with Also, code on the Thanks and Cheers! |
2718f45
to
85343de
Compare
85343de
to
e6249f0
Compare
Thanks, I have rebased and resolved conflicts. I have used collections.abc instead of six.moves.collections_abc since the repo is Python 3.6 + only. The lint stage passes now. This change was implemented in Python 3.10 and will become an error : python/cpython#23754 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A maintainer will need to approve and merge it.
Thanks @cognifloyd |
Thanks, @cognifloyd for the heads up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution, @tirkarthi and @cognifloyd for review!
Thanks all for the review and merge. |
Closes #5006