Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change EnforceNetworkRulesForInternalStages ddl to parameter #3343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: change EnforceNetworkRulesForInternalStages ddl to parameter #3343

wants to merge 1 commit into from

Conversation

yuukiyamanaka
Copy link

@yuukiyamanaka yuukiyamanaka commented Jan 18, 2025 •
edited
Loading

ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES requires boolean parameter so I change the setting from ddl:keyword to ddl:parameter.

Test Plan

  • acceptance tests
  • …

References

#3344

@yuukiyamanaka yuukiyamanaka mentioned this pull request Jan 18, 2025
Open
1 task
@sfc-gh-jmichalak sfc-gh-jmichalak changed the title fix: change_enforce_network_policy_parameter_to_ddl_parameter fix: change EnforceNetworkRulesForInternalStages ddl to parameter Jan 20, 2025
sfc-gh-jmichalak
sfc-gh-jmichalak requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the target branch to dev we will update the contribution guide about this change.

Also, there is a missing entry about the fix from the migration guide, but we can add it on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuukiyamanaka @sfc-gh-jmichalak