chore: remove generating integration tests placeholder file #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fbudzynski
changed the title
sfc-gh-jcieslak
previously approved these changes
Dec 9, 2024
pkg/sdk/poc/generator/templates/sub_templates/implementation_functions.tmpl
Show resolved
Hide resolved
sfc-gh-jmichalak
previously approved these changes
Dec 9, 2024
|
Integration tests failure for 425b967a04f1892d1cea129e9f5e43d7c0db3291 |
|
Integration tests failure for c24627ff1a0fc7f16035c3d8b802990a95187f3c |
sfc-gh-fbudzynski
dismissed stale reviews from sfc-gh-jmichalak and sfc-gh-jcieslak
via
b058577
|
Integration tests failure for 235da097b3c1ff70e6dffb993c9800108039085c |
|
Integration tests failure for b058577f01dc00503a4fa9b0833d062ee0a106a9 |
sfc-gh-fbudzynski
requested review from
sfc-gh-jmichalak and
sfc-gh-jcieslak
|
Integration tests failure for f6a0e67126a087d42e5a1d7c5c47ce51f380e2a5 |
|
Integration tests failure for e97a0f5d2959875c88970067fc7982d20631c930 |
|
Integration tests failure for de6191799ead338bef687658735d81ec4db91bf7 |
sfc-gh-jcieslak
previously approved these changes
Dec 13, 2024
…nowflake into sdk-remove-integration-tests-generation
sfc-gh-jmichalak
approved these changes
Dec 16, 2024
|
Integration tests failure for 5759b9cb5cad83878ce79ffd89b7894b732abc95 |
sfc-gh-fbudzynski
deleted the
sdk-remove-integration-tests-generation
branch
sfc-gh-asawicki
pushed a commit
that referenced
this pull request
Dec 20, 2024
<!-- Feel free to delete comments as you fill this in --> <!-- summary of changes --> ## Changes - removed generation of integration_tests file - added a print for the user to create the integration tests manually - changed the `ShowByIdOperation` name to `ShowByIdOperationNoFiltering` for no automatic generation of filtering options - adjusted the template for ShowByID filtering - removed `ShowByIDNoFiltering` option (replaced by `ShowByIdOperationNoFiltering`) - adjusted README of the SDK generator to the current state ## References <!-- issues documentation links, etc --> * #3227 * #3240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ShowByIdOperationname toShowByIdOperationNoFilteringfor no automatic generation of filtering optionsShowByIDNoFilteringoption (replaced byShowByIdOperationNoFiltering)References