Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Account v1 readiness generated files #3242

Merged
merged 15 commits into from
Dec 6, 2024
Merged

feat: Account v1 readiness generated files #3242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7dfda5f
wip
sfc-gh-jcieslak Nov 26, 2024
c299672
wip
sfc-gh-jcieslak Nov 26, 2024
15ad29a
wip
sfc-gh-jcieslak Nov 28, 2024
de39050
wip
sfc-gh-jcieslak Nov 28, 2024
461511e
wip
sfc-gh-jcieslak Dec 2, 2024
6d75c93
wip
sfc-gh-jcieslak Dec 2, 2024
7e6b8a3
wip
sfc-gh-jcieslak Dec 2, 2024
530aa0d
fix tests
sfc-gh-jcieslak Dec 2, 2024
cd98aef
wip
sfc-gh-jcieslak Dec 3, 2024
3cf2e6c
wip
sfc-gh-jcieslak Dec 3, 2024
09b8429
wip
sfc-gh-jcieslak Dec 3, 2024
13872f1
wip
sfc-gh-jcieslak Dec 3, 2024
3343375
wip
sfc-gh-jcieslak Dec 3, 2024
f6ebd3f
Merge branch 'refs/heads/main' into account-v1-readiness-generated-files
sfc-gh-jcieslak Dec 6, 2024
a12ca9d
wip
sfc-gh-jcieslak Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/acceptance/bettertestspoc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ func (w *WarehouseDatasourceShowOutputAssert) IsEmpty() {
- consider merging ResourceModel with DatasourceModel (currently the implementation is really similar)
- remove schema.TypeMap workaround or make it wiser (e.g. during generation we could programmatically gather all schema.TypeMap and use this workaround only for them)
- support asserting resource id in `assert/resourceassert/*_gen.go`
- add possibility for object parameter assert not take any identifier (currently there's a workaround in `account_parameters_snowflake_gen.go`, because `SHOW PARAMETERS FOR ACCOUNT` don't take any identifiers)

## Known limitations
- generating provider config may misbehave when used only with one object/map paramter (like `params`), e.g.:
Expand Down
Loading
Loading