Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant commands to automatically include SSL_CERT_FILE and CURL_CA_BUNDLE if they are set #47

Merged
merged 4 commits into from
Jun 19, 2020

Conversation

pdmthorsrud
Copy link
Contributor

@pdmthorsrud pdmthorsrud commented Jun 18, 2020

A proposed solution to #43. Will not fail if the env variables are empty.
Example below:
image

closes #43

@pdmthorsrud pdmthorsrud self-assigned this Jun 18, 2020
@pdmthorsrud pdmthorsrud changed the title Feature/make ca Vagrant commands to automatically include SSL_CERT_FILE and CURL_CA_BUNDLE if they are set Jun 18, 2020
@pdmthorsrud
Copy link
Contributor Author

pdmthorsrud commented Jun 18, 2020

As Nikita pointed out, the vagrant up I've modified here does actually not go to vagrantcloud, so it isn't necessary, but it shows how it could be done other places where vagrant up fails with an SSL error when SSL_CERT_FILE and CURL_CA_BUNDLE is not set.

Added an update and up rule in the root directory to show possible solution.

@zhenik
Copy link
Contributor

zhenik commented Jun 18, 2020

Current solution work fine.
I tested it with

  • Mac, no transparent proxy, home-wifi network
  • VDI, transparent poxy, office network

@pdmthorsrud
Copy link
Contributor Author

I also like this approach because it assume no transparent proxy as default, and if they are behind a transparent proxy it forces a change within their own system, nothing in our source code. At the same time we don't need to make different versions of the rules in our makefiles etc., meaning the way you use our code will always stay the same.

@fredrikhgrelland fredrikhgrelland marked this pull request as ready for review June 19, 2020 07:33
@fredrikhgrelland fredrikhgrelland merged commit 844f71c into Skatteetaten:master Jun 19, 2020
@pdmthorsrud pdmthorsrud deleted the feature/make-ca branch June 25, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aliasing for vagrant binary including CA trust for internal transparent proxy
3 participants