Improve CSS imports #639
Merged
Improve CSS imports #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizkenyon
approved these changes
Mar 25, 2024
|
@paulomarg just a headsup i tested this and I think it breaks vite builds there's a fix in the remix package now so maybe updating the dependency in the template to |
|
Yeah, it looks like updating is the right fix here - new apps won't have a lock file, so they should automatically get the latest version. We'll still update the template's For existing apps, updating should fix that! Thanks for digging into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
In some cases, importing global frontend CSS files as modules can cause the CSS to be wiped out when a file is saved and triggers an HMR reload in the template.
WHAT is this pull request doing?
Loading global CSS files whose classes we don't need to reference in the code with a
?urlflag so they're loaded from the URL, and don't break on HMR reloads.