Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation suggesting that update-todo can be run with specificed files #324

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

andrewn617
Copy link
Contributor

What are you trying to accomplish?

TROUBLESHOOTING.md still says that you can run packwerk update-todo with a package specified as an option. This capability was removed in by #272.

What approach did you choose and why?

Removed it from the documentation.

What should reviewers focus on?

Everything.

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.

If no additional notes are necessary, delete this section or leave it unchanged.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

@andrewn617 andrewn617 requested a review from a team as a code owner March 7, 2023 18:32
@gmcgibbon gmcgibbon changed the title Remove documentation suggesting that update-todo can be run with spec… Remove documentation suggesting that update-todo can be run with specificed files Mar 7, 2023
@gmcgibbon gmcgibbon merged commit c24077e into main Mar 7, 2023
@gmcgibbon gmcgibbon deleted the andrewn617-20230307-update-packwerk-documentation branch March 7, 2023 19:45
@gmcgibbon
Copy link
Member

Thanks!

@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 9, 2023 00:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants