New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate `@shopify/shopify_function` version on build #5153

Merged

andrewhassan merged 3 commits into main from ah.validate-shopify-function-package-version

Jan 13, 2025

+79 −16

Merged

Validate `@shopify/shopify_function` version on build #5153

Add changeset

GitHub Actions / ESLint Report Analysis succeeded Jan 6, 2025 in 0s

ESLint Report Analysis

0 ESLint error(s) and 3 ESLint warning(s) found in pull request changed files.

Details

Annotations

Check warning on line 366 in packages/app/src/cli/services/function/build.ts

github-actions / ESLint Report Analysis

packages/app/src/cli/services/function/build.ts#L366

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 85 in packages/app/src/cli/services/generate/extension.ts

github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/extension.ts#L85

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 177 in packages/app/src/cli/services/generate/extension.ts

github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/extension.ts#L177

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

View more details on GitHub Actions