Merge pull request #5011 from Shopify/jc.set-overwrite-flag-stable

Fix dest already exists error by setting overwrite flag on stable branch
Shopify · Dec 3, 2024 · 9b8c291 · 9b8c291
2 parents e643396 + 4b93d76
commit 9b8c291
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/khaki-glasses-wave.md b/.changeset/khaki-glasses-wave.md
@@ -0,0 +1,5 @@
+---
+'@shopify/app': patch
+---
+
+Fix error when downloading Javy plugin in parallel
diff --git a/packages/app/src/cli/services/function/binaries.ts b/packages/app/src/cli/services/function/binaries.ts
@@ -164,7 +164,7 @@ export async function downloadBinary(bin: DownloadableBinary) {
         const outputStream = createFileWriteStream(tmpFile)
         await bin.processResponse(responseStream, outputStream)
         await chmod(tmpFile, 0o775)
-        await moveFile(tmpFile, bin.path)
+        await moveFile(tmpFile, bin.path, {overwrite: true})
       })
     },
     async () => {},