Merge pull request #5209 from Shopify/jm/01-15-unify_asset_upload_err…

…or_reporting

[Themes] `theme dev` - unify asset upload error reporting

.changeset/stupid-phones-try.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme': minor
+---
+
+Unify how asset upload errors are reported in the `theme dev` command

packages/theme/src/cli/utilities/theme-uploader.ts

@@ -1,12 +1,12 @@
 import {partitionThemeFiles} from './theme-fs.js'
 import {rejectGeneratedStaticAssets} from './asset-checksum.js'
 import {renderTasksToStdErr} from './theme-ui.js'
-import {createSyncingCatchError} from './errors.js'
+import {createSyncingCatchError, renderThrownError} from './errors.js'
 import {AdminSession} from '@shopify/cli-kit/node/session'
 import {Result, Checksum, Theme, ThemeFileSystem} from '@shopify/cli-kit/node/themes/types'
 import {AssetParams, bulkUploadThemeAssets, deleteThemeAsset} from '@shopify/cli-kit/node/themes/api'
 import {Task} from '@shopify/cli-kit/node/ui'
-import {outputDebug, outputInfo, outputNewline, outputWarn} from '@shopify/cli-kit/node/output'
+import {outputDebug} from '@shopify/cli-kit/node/output'
 
 interface UploadOptions {
   nodelete?: boolean
@@ -432,10 +432,8 @@ async function handleFailedUploads(
 function reportFailedUploads(uploadResults: Map<string, Result>) {
   for (const [key, result] of uploadResults.entries()) {
     if (!result.success) {
-      const errorMessage = result.errors?.asset?.map((err) => `-${err}`).join('\n')
-      outputWarn(`Failed to upload file ${key}:`)
-      outputInfo(`${errorMessage}`)
-      outputNewline()
+      const errorMessage = result.errors?.asset?.join('\n') ?? 'File upload failed'
+      renderThrownError(key, new Error(errorMessage))
     }
   }
 }