Merge pull request #5207 from Shopify/no-color-fix

`--no-color` fix
Shopify · Jan 19, 2025 · 5159ef6 · 5159ef6
2 parents a7e2043 + 3693514
commit 5159ef6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/smart-carrots-vanish.md b/.changeset/smart-carrots-vanish.md
@@ -0,0 +1,5 @@
+---
+'@shopify/cli-kit': patch
+---
+
+Ensure no-color mode is respected for warnings and errors
diff --git a/packages/cli-kit/src/public/node/output.ts b/packages/cli-kit/src/public/node/output.ts
@@ -371,7 +371,7 @@ export interface OutputProcess {
  * @param message - The message to print.
  */
 export function consoleLog(message: string): void {
-  console.log(withOrWithoutStyle(message))
+  process.stdout.write(`${withOrWithoutStyle(message)}\n`)
 }
 
 /**
@@ -380,7 +380,7 @@ export function consoleLog(message: string): void {
  * @param message - The message to print.
  */
 export function consoleError(message: string): void {
-  console.error(withOrWithoutStyle(message))
+  process.stderr.write(`${withOrWithoutStyle(message)}\n`)
 }
 
 /**
@@ -389,7 +389,7 @@ export function consoleError(message: string): void {
  * @param message - The message to print.
  */
 export function consoleWarn(message: string): void {
-  console.warn(withOrWithoutStyle(message))
+  process.stderr.write(`${withOrWithoutStyle(message)}\n`)
 }
 
 /**