Merge pull request #5196 from Shopify/shauns/01-15-fix_error_handler_…

…for_invalid_toml_files Fix error handler for invalid TOML files
Shopify · Jan 15, 2025 · 3135ec6 · 3135ec6
2 parents 271e28c + 4969c1f
commit 3135ec6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/small-guests-brake.md b/.changeset/small-guests-brake.md
@@ -0,0 +1,5 @@
+---
+'@shopify/app': patch
+---
+
+Better error message for certain types of invalid app TOML files
diff --git a/packages/app/src/cli/models/app/loader.ts b/packages/app/src/cli/models/app/loader.ts
@@ -82,7 +82,7 @@ export async function loadConfigurationFileContent(
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
   } catch (err: any) {
     // TOML errors have line, pos and col properties
-    if (err.line && err.pos && err.col) {
+    if (err.line !== undefined && err.pos !== undefined && err.col !== undefined) {
       return abortOrReport(
         outputContent`Fix the following error in ${outputToken.path(filepath)}:\n${err.message}`,
         {},