Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(LabelExampleImageColored): update example to match image names #3881

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

isnifer
Copy link
Contributor

@isnifer isnifer commented Jan 9, 2020

Replace Veronika with jenny due to image name

@welcome
Copy link

welcome bot commented Jan 9, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

@MonkeyAlex MonkeyAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.
If you're keen, you may also correct the next label from Helen to Christian (see line#18)

Replace Veronika with jenny due to image name
@codecov-io
Copy link

Codecov Report

Merging #3881 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3881   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         178      178           
  Lines        3150     3150           
=======================================
  Hits         3145     3145           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbab6b...feb998a. Read the comment docs.

@isnifer
Copy link
Contributor Author

isnifer commented Jan 28, 2020

@MonkeyAlex did it)

@codecov-commenter
Copy link

Codecov Report

Merging #3881 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3881      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files         183      178       -5     
  Lines        3157     3150       -7     
==========================================
- Hits         3152     3145       -7     
  Misses          5        5              
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100.00% <0.00%> (ø)
src/modules/Transition/Transition.js 100.00% <0.00%> (ø)
src/behaviors/Visibility/Visibility.js 100.00% <0.00%> (ø)
src/modules/Transition/TransitionGroup.js 100.00% <0.00%> (ø)
...ddons/TransitionablePortal/TransitionablePortal.js 100.00% <0.00%> (ø)
src/modules/Transition/utils/wrapChild.js
src/modules/Dropdown/utils/getMenuOptions.js
src/modules/Transition/utils/childMapping.js
src/modules/Dropdown/utils/getSelectedIndex.js
src/modules/Transition/utils/computeStatuses.js
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf6431...3ac5ca7. Read the comment docs.

@layershifter layershifter changed the title docs(LabelExampleImageColored): Update example docs(LabelExampleImageColored): update example to match image names Jul 24, 2020
@layershifter layershifter merged commit c1c0152 into Semantic-Org:master Jul 24, 2020
@welcome
Copy link

welcome bot commented Jul 24, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@isnifer isnifer deleted the patch-1 branch July 26, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants