Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): aria-live region needs aria-atomic #3621

Merged
merged 2 commits into from
May 26, 2019

Conversation

fracmak
Copy link
Member

@fracmak fracmak commented May 24, 2019

Did an audit of our site with NVDA and ran into a problem where dropdowns act kind of funny depending on the order of the values in the dropdown. Apparently aria-live regions only read what changes in the region unless you specify aria-atomic to read the entire area aloud. This means that if you have a dropdown like this

Within 25 miles
Within 50 miles
Within 125 miles
Within 250 miles
Within 500 miles
More than 500 miles

The screen reader reads these options as 'Within 25 miles', '50', '125', '0'

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions#Advanced_live_regions

@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #3621 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3621   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         174      174           
  Lines        2744     2744           
=======================================
  Hits         2739     2739           
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e595719...8fc28ad. Read the comment docs.

@layershifter layershifter merged commit 30d93a3 into Semantic-Org:master May 26, 2019
mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants