fix(Dropdown): aria-live region needs aria-atomic #3621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did an audit of our site with NVDA and ran into a problem where dropdowns act kind of funny depending on the order of the values in the dropdown. Apparently aria-live regions only read what changes in the region unless you specify aria-atomic to read the entire area aloud. This means that if you have a dropdown like this
The screen reader reads these options as 'Within 25 miles', '50', '125', '0'
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions#Advanced_live_regions