BREAKING (Sidebar): remove duration
prop
#3336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duration
prop has been removed from theSidebar
component. However I've maintained a static variable in theSidebar
class to still provide the default duration of 500 ms that is used to manage the callback cycle when showing and hiding the sidebar.@layershifter, as
animationDuration
is now a static prop it can actually be assigned externally (like I've done in the modified tests for this PR). If that's ok, should we add that to the type definitions? It could be done as easily as modifying theSidebar
type declaration in the end ofSidebar.d.ts
to something like:Cheers!
(Closes #3328)