Skip to content

Commit

Permalink
[Major] Rename createdomainv2 to createdomain
Browse files Browse the repository at this point in the history
  • Loading branch information
Seikho committed Mar 5, 2022
1 parent 01523b1 commit cb3d6e4
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 13 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [Command Handlers](https://seikho.github.io/evtstore/#/docs/commands)

**Note: `createDomain` will be migrating to `createDomainV2` in version 11.x**
The `createDomainV2` API solves circular reference issues when importing aggregates.
The original `createDomain` will be available as `createDomainV1` from 11.x onwards.

## Why
Expand Down
4 changes: 2 additions & 2 deletions index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export { createDomain, createDomainV1 } from './src/domain'
export { createDomainV1 } from './src/domain'
export { createHandler } from './src/create-handler'
export { createBookmark } from './src/create-bookmark'
export { createDomainV2, createStore } from './src/domain-v2'
export { createDomainV2, createDomain } from './src/domain-v2'
export { createAggregate, createProvidedAggregate } from './src/create-aggregate'
export { createCommands } from './src/create-command'
export {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "evtstore",
"version": "10.2.0",
"version": "11.0.0",
"description": "Event Sourcing with Node.JS",
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/domain-v2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ type ExtStoreAggEvent<T> = T extends StorableAggregate<infer E, any, any> ? E :

type ExtStreams<T extends AggregateStore> = T[keyof T]['stream']

export function createStore<Tree extends AggregateStore>(opts: StoreOpts, aggregates: Tree) {
export function createDomain<Tree extends AggregateStore>(opts: StoreOpts, aggregates: Tree) {
return createDomainV2(opts, aggregates)
}

Expand Down
7 changes: 0 additions & 7 deletions src/domain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ import { createProvidedAggregate } from './create-aggregate'
export function createDomainV1<Evt extends Event, Agg extends Aggregate, Cmd extends Command>(
opts: DomainOptions<Evt, Agg>,
cmd: CommandHandler<Evt, Agg, Cmd>
) {
return createDomain(opts, cmd)
}

export function createDomain<Evt extends Event, Agg extends Aggregate, Cmd extends Command>(
opts: DomainOptions<Evt, Agg>,
cmd: CommandHandler<Evt, Agg, Cmd>
): Domain<Evt, Agg, Cmd> {
function handler(bookmark: string) {
return new EventHandler({
Expand Down
2 changes: 1 addition & 1 deletion src/test/memory.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { expect } from 'chai'
import { createProvider } from '../../provider/memory'
import { createDomain } from '../domain'
import { createDomainV1 as createDomain } from '../domain'
import { ExampleEv, ExampleAgg, ExampleCmd, exampleFold, exampleCmd } from './example'

const { command, getAggregate, handler } = createDomain<ExampleEv, ExampleAgg, ExampleCmd>(
Expand Down
2 changes: 1 addition & 1 deletion src/test/tests.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Handler, Provider, Domain } from '../types'
import { ExampleEv, ExampleAgg, ExampleCmd, exampleFold, exampleCmd } from './example'
import { BaseAggregate } from '../types'
import { createDomain } from '../domain'
import { createDomainV1 as createDomain } from '../domain'
import { expect } from 'chai'
import { MemoryBookmark } from '../common'
import { createHandler } from '../create-handler'
Expand Down

0 comments on commit cb3d6e4

Please sign in to comment.