Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromes: Add hash extraction and all chrome versions #2144

Merged
merged 48 commits into from
Jun 30, 2019
Merged

Chromes: Add hash extraction and all chrome versions #2144

merged 48 commits into from
Jun 30, 2019

Conversation

Ash258
Copy link
Contributor

@Ash258 Ash258 commented May 14, 2019 •
edited
Loading

Thx @h404bi for website ❤😍

This should be merged when ScoopInstaller/Scoop#3458 is in master

TODO:

@chawyehsu
Copy link
Member

chawyehsu commented May 14, 2019 •
edited
Loading

I strongly recommend to use googlechrome instead of chrome as the manifest name. People can search googlechrome or chrome to find the app when they are named googlechrome, while only chrome if they are named chrome. Google Chrome is a brand, Chrome is not, it's just a shortname.

@Ash258
Copy link
Contributor Author

Ash258 commented May 14, 2019

I really do not mind naming. If googlechrome is more suitable for more users i will git mv them to googlechrome prefix

@Ash258
Copy link
Contributor Author

Ash258 commented May 18, 2019

@ScoopInstaller Thoughts on naming?

**Note: Not sure if @scoopinstaller will trigger notification for all members 🤔

@Ash258
Copy link
Contributor Author

Ash258 commented May 23, 2019

Canary sometimes have different versions for each architecture

a

Ash258 referenced this pull request Jun 6, 2019
@Ash258 @rasa
Add Chrome 73.0.3683.86 (#1931)
c1456fd
@NamelessUzer
Copy link
Contributor

#3458 has been merged, why this PR hasn't been merged so far?

@Ash258
Copy link
Contributor Author

Ash258 commented Jun 6, 2019

#2144 (comment)

@Ash258
Copy link
Contributor Author

Ash258 commented Jun 6, 2019

Thoughts / Votes about renaming? @r15ch13, @niheaven, @h404bi, @rasa, @brandon93s, @se35710, @NatoBoram

chrome -> googlechrome
chrome-beta -> googlechrome-beta
chrome-canary -> googlechrome-canary
chrome-dev -> googlechrome-dev

🚀 Old
👀 New

@NatoBoram
Copy link

I don't mind the renaming. If installing fails, I'd typically look up on the GitHub repo and see why. It's an easy fix for downstream, and the error message is explicit enough.

On the topic of renaming, I'd rename pwsh 🙂

@rasa
Copy link
Member

rasa commented Jun 8, 2019 •
edited
Loading

+1 to rename, as chocolatey uses googlechrome
https://chocolatey.org/packages?q=Chrome

@niheaven niheaven mentioned this pull request Jun 18, 2019
Closed
@rasa rasa mentioned this pull request Jun 19, 2019
Closed
Ash258 added 13 commits June 22, 2019 00:37
@rasa
Copy link
Member

rasa commented Jun 29, 2019

Is this GTG?

@Ash258
Copy link
Contributor Author

Ash258 commented Jun 29, 2019

From 15th of May

@linsui
Copy link
Contributor

linsui commented Jun 30, 2019

  • TODO:

Simplify installer.script with Expand-7zipArchive \"$dir\\chrome.7z\" -ExtractDir 'Chrome-bin' -Removal (When ScoopInstaller/Scoop#3466 is in master)

When will this be done?

@Ash258
Copy link
Contributor Author

Ash258 commented Jun 30, 2019

in next PR

@rasa rasa merged commit ee1e6d9 into ScoopInstaller:master Jun 30, 2019
@Ash258 Ash258 deleted the chromes branch June 30, 2019 13:55
@linsui linsui mentioned this pull request Aug 21, 2019
Closed
@SukkaW SukkaW mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chawyehsu chawyehsu chawyehsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Chrome Beta, Dev, and Canary
6 participants
@Ash258 @chawyehsu @NamelessUzer @NatoBoram @rasa @linsui