-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wip] Refactor "src/dsl.jl" file #985
Open
TorkelE
wants to merge
40
commits into
master
Choose a base branch
from
src___refactoring___dsl_file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+945
−624
Open
Changes from 38 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
efd44be
save progress
TorkelE d2985c0
save progress
TorkelE b06068f
save progress
TorkelE 5cc8f41
save progress
TorkelE 15273f1
save progress
TorkelE b105b3e
add additional tests
TorkelE 1324428
up
TorkelE 71c9b5c
fix
TorkelE 9ab9290
Merge branch 'master' into dsl_file_improvements
TorkelE d45f0a7
merge fixes
TorkelE b6ba044
Merge branch 'master' into src___refactoring___dsl_file
TorkelE cdac225
merge fixes
TorkelE ea9aae3
up
TorkelE 7084133
test fixes
TorkelE a6b4c3a
format
TorkelE 160668f
up
TorkelE 9c265ee
observables fix
TorkelE 34fc2c0
spatial transport reaction dsl fix
TorkelE e9fa7ba
Merge branch 'master' into src___refactoring___dsl_file
TorkelE 37ea1d9
iv is now a parmaeter
TorkelE 87464f7
Add tests for various erroneous declarations
TorkelE 8156eca
update old @variable test
TorkelE fba3f5e
Merge branch 'master' into src___refactoring___dsl_file
TorkelE 50f8f82
save progress
TorkelE 4e720ee
save progress
TorkelE a1e967a
save progress
TorkelE fadeb67
Merge branch 'master' into src___refactoring___dsl_file
TorkelE b235784
save progress
TorkelE 18fcbf1
prepare formatting round
TorkelE 9230667
up
TorkelE 78ca087
multiple fixes
TorkelE 9d62c28
docstring fix
TorkelE 9a928fe
fixes
TorkelE 53a6254
up
TorkelE 27f7add
fix function expansion of differentials
TorkelE 99e54d2
spelling fix
TorkelE 7ec7383
better handling of forbidden symbols and more tests
TorkelE 5f35480
improve option error handling, more tests
TorkelE 292da20
minor upodates after read through
TorkelE 2902101
doc fix, combinatorial_ratelaw error handling
TorkelE File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,11 +72,6 @@ const CONSERVED_CONSTANT_SYMBOL = :Γ | |
const forbidden_symbols_skip = Set([:ℯ, :pi, :π, :t, :∅]) | ||
const forbidden_symbols_error = union(Set([:im, :nothing, CONSERVED_CONSTANT_SYMBOL]), | ||
forbidden_symbols_skip) | ||
const forbidden_variables_error = let | ||
fvars = copy(forbidden_symbols_error) | ||
delete!(fvars, :t) | ||
fvars | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Per discussion, this one is not actually used. |
||
|
||
### Package Main ### | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,7 +86,7 @@ function make_compound(expr) | |
# Cannot extract directly using e.g. "getfield.(composition, :reactant)" because then | ||
# we get something like :([:C, :O]), rather than :([C, O]). | ||
composition = Catalyst.recursive_find_reactants!(expr.args[3], 1, | ||
Vector{ReactantStruct}(undef, 0)) | ||
Vector{DSLReactant}(undef, 0)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better name so that it is not confused with other structures (thanks for the name suggestion) |
||
components = :([]) # Becomes something like :([C, O]). | ||
coefficients = :([]) # Becomes something like :([1, 2]). | ||
for comp in composition | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously there was actually no section on this in the DSL. The updated
@reaction
docstring now references this one.