-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial for using Optimization and DiffEqParamEstim for parameter fitting #708
Conversation
Currently ready for Vaibhav to have a look at. There is one problem, this bit (when fitting two data both for
Is there some easy modification to options I can provide to make this work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this fit in with the current Optimization based tutorial?
Also, why use CMAEvolutionStrategyOpt
?
docs/src/catalyst_applications/optimization_ode_param_fitting.md
Outdated
Show resolved
Hide resolved
That will be moved to an separate example (and rewritten a bit and be a focus on Fitting parameters of oscillatory processes).
I just picked one (don't really know much on sensible selection of optimisation methods), happy to change. |
I second Sam's point above, CMAES doesn't seem like a good choice here. I would recommend using a first order method (BFGS) instead, you can use it from NLopt so that'll cover multiple solver packages as well which might be useful for users to see. |
Yeah, I just wanted to select a optimiser from another package, I can change to that one. |
Updated to use BFGS instead. |
docs/src/catalyst_applications/optimization_ode_param_fitting.md
Outdated
Show resolved
Hide resolved
This is ready for merging now. |
5164233
to
ce8ddae
Compare
Will go through and check the merge and latest updates this evening. But in summary, this is now rebased on master (where the inverse problem section exists). I have also moved the previous parameter fitting tutorial to a sub folder for examples, and rewritten it a bit to make it an example of how to fit an oscillation (while this new tutorial simply shows the SciML/Optimization workflow). |
947ff06
to
80a2e8d
Compare
I need to go through this carefully still, but I think I’m going to have the same comment about not dynamically generating graphs and such. |
See the reply there. Yes, I agree. I will see what can be done. We could always merge and put in an issue that this should be dealt with at some point of time (although we are starting to get so many issues that it is easy for stuff to get lost there, which makes me slightly reluctant) |
This one is ready for merging |
Ok, I’ll let you know once I’ve read it carefully. |
d1680a7
to
bc47caa
Compare
f20d62a
to
f624106
Compare
Co-authored-by: Vaibhav Kumar Dixit <vaibhavyashdixit@gmail.com>
replaced by #740 |
Adds a single tutorial page. Currently put under
catalyst_applications
. Once #701 passes I will separately add this to the inverse problem section.The base tutorial is done (but needs to be reread a bit), but some auxiliary sections need to be added.