Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button group to allow for proper logic of radio buttons #2842

Closed
wants to merge 1 commit into from

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Apr 8, 2024

Description

When opencl is not present, the only option on the GPU Options dialog is "No OpenCL".
However, this "radio" button could be deselected and deselecting it caused issues when running tests.

This has been fixed by adding a QButtonGroup to add all the radio buttons into a layout.

Fixes #2841

How Has This Been Tested?

Local Win10 build

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • [X ] There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Member

@juliuskarliczek juliuskarliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested RadioButton functionality on local win10 build with and without pyopencl installed. Works perfectly fine for me. RadioButton cannot be deselected anymore

@rozyczko rozyczko changed the base branch from main to release_6.0.0 April 9, 2024 13:16
@rozyczko rozyczko changed the base branch from release_6.0.0 to main April 9, 2024 13:16
@krzywon
Copy link
Contributor

krzywon commented Apr 11, 2024

With our process for merging release branches back into main, I think this PR should closed in favor of #2848.

@rozyczko
Copy link
Member Author

closing as per comment

@rozyczko rozyczko closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No OpenCL Radiobutton can be deselected
3 participants