Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config from list of variables to class #2164

Closed
lucas-wilkins opened this issue Aug 19, 2022 · 2 comments · Fixed by #2168
Closed

Update config from list of variables to class #2164

lucas-wilkins opened this issue Aug 19, 2022 · 2 comments · Fixed by #2168
Assignees
Labels
Blocker Prevents a different issue from being resolved Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general Infrastructure GitHub, project structure, community etc

Comments

@lucas-wilkins
Copy link
Contributor

Use a class to specify the config, so its clear what variable should and shouldn't be there. It's hard to keep things tidy when you can't easily trace usages.

@lucas-wilkins lucas-wilkins added Infrastructure GitHub, project structure, community etc Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general labels Aug 19, 2022
@lucas-wilkins lucas-wilkins self-assigned this Aug 19, 2022
@lucas-wilkins lucas-wilkins added the Blocker Prevents a different issue from being resolved label Aug 19, 2022
@lucas-wilkins
Copy link
Contributor Author

Step 1: Move config stuff (custom_config, local_config, LocalConfig and their copies) into a single class that can be inspected
Step 2: Make config IO work with yaml, NO OUTPUTTING PYTHON CODE
Step 3: Remove any usused config items
Step 4: Relocate any items that don't belong
Step 5: Make config more of a data container by removing any methods and dynamic stuff
Step 6: Rename config items in a consistent way
Step 7: Add schema for validating config files

@lucas-wilkins
Copy link
Contributor Author

TODO: images should be located using importlib, not through ad-hoc dynamic paths in config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Prevents a different issue from being resolved Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general Infrastructure GitHub, project structure, community etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant