Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2162 Avoid double input in data point properties edition #3095

Open
wants to merge 3 commits into
base: release/2.8.0
Choose a base branch
from

Conversation

Patrykb0802
Copy link
Contributor

  • Now changing engineeringUnits is Point Properties view will change its suffix to the according one
  • Now changing number format in text renderer will automatically change tolerance in logging properties of the point

- Now changing engineeringUnits is Point Properties view will change its suffix to the according one
- Now changing number format in text renderer will automatically change tolerance in logging properties of the point
Copy link

github-actions bot commented Feb 22, 2025

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✅ ±0   3s ⏱️ ±0s
 70 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c29ff44. ± Comparison against base commit 16f0307.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 22, 2025

Java JUnit Test Results

3 110 tests  +380   3 110 ✅ +380   43s ⏱️ ±0s
  119 suites +  1       0 💤 ±  0 
  119 files   +  1       0 ❌ ±  0 

Results for commit c29ff44. ± Comparison against base commit 16f0307.

♻️ This comment has been updated with latest results.

- Added attribute 'unitsMap' to 'engineeringUnits' tag, and refactoring generate select;
- Created enums EngineeringUnitsTypes, created class EngineeringUnitJson for serialize units, and created interface EngineeringUnit;
- Added test: EngineeringUnitsTypesTest;
- Removed method: DataPointEditDwr.getEngineeringUnitSuffix;
- In DataPointEditController.showForm and DataPointEditController.saveDataPoint added attributes: unitsMap, unitsListJson;
- Refactor function updateSuffixForEngineeringUnits in dataPointEdit.jsp, added set value for fields: textRendererPlainSuffix and textRendererAnalogFormat;
- Corrected handler exception;
- Moved EngineeringUnitJson to org.scada_lts.web.mvc.api package;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants