2.00.0 - RFC Ready - Major Base Change!

.cspell.json

@@ -52,7 +52,11 @@
     "msgty",
     "msgno",
     "UNDETEC",
-    "SLIN"
+    "SLIN",
+    "struc",
+    "stmnt",
+    "kaizen",
+    "quickfix"
   ],
   // flagWords - list of words to be always considered incorrect
   // This is useful for offensive words and common spelling errors.

README.md

@@ -4,38 +4,91 @@
 [![license](https://img.shields.io/github/license/SAP/code-pal-for-abap)](LICENSE)
 [![REUSE status](https://api.reuse.software/badge/github.com/SAP/code-pal-for-abap)](https://api.reuse.software/info/github.com/SAP/code-pal-for-abap)
 
-Based on the [Clean ABAP](/~https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md), this tool contains a set of checks to guarantee the [Clean ABAP](/~https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md) adherence.  
+Based on the [Clean ABAP](/~https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md), this tool contains a set of rules to support [Clean ABAP](/~https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md) adherence.  
 Together, we both support you in writing a clean ABAP code. 
 
 ❣️ It's **free** and **open-source**.
 
 ## Features
 
-- Supported by Code Inspector (`SCI` / `SCII`) and ABAP Test Cockpit (ATC) (`SE80` / Eclipse);
-- Ignores automatically generated code;
-- Supports exemptions;
-- Provides a new user-friendly way to create variants ([Profile Management](pages/how-to-configure.md));
+- Supports local and remote inspections;
+- Supports SAP GUI and Eclipse (ADT);
+- Supports ABAP Test Cockpit (ATC) and Code Inspector (SCI);
+- Skips generated code; 
+- Allows exemptions;
 - Allows configuration based on:
-  - Threshold;
-  - Severity / Priority;
-  - Validity for productive code, test code, or both;
-  - Validity for objects created since a specific date;
-  - Validity period;
-  - Allow / Deny exemption.
-
-⚠️ Tool is not RFC-Enabled ([#268](/~https://github.com/SAP/code-pal-for-abap/issues/268)). 
-
-⚠️ Severities set to `Notification` / `Priority 3` by default ([#368](/~https://github.com/SAP/code-pal-for-abap/issues/368)).
+  - Rule validity;
+  - Rule severity (priority);
+  - Rule threshold;
+  - Rule relevance for productive and test codes;
+  - Rule relevance for objects created since a specific date;
+  - Rule relevance for new child objects;
+  - Rule relevance for exemptions.
 
 ## Set of Checks
 
-- [Check Documentation](docs/check_documentation.md)
+- [Avoid DEFAULT KEY](checks/avoid-default-key.md)
+- [Boolean Input Parameter](checks/boolean-input-parameter.md)
+- [CALL Method Usage](checks/call-method-usage.md)
+- [Chain Declaration Usage](checks/chain-declaration-usage.md)
+- [CHECK Statement Position](checks/check-statement-position.md)
+- [CHECK in LOOP](checks/check-in-loop.md)
+- [COLLECT restriction](checks/collect.md)
+- [Combination of Output Parameters](checks/method-output-parameter.md)
+- [Comment Position](checks/comment-position.md)
+- [Comment Type](checks/comment-type.md)
+- [Comment Usage](checks/comment-usage.md)
+- [Constants Interface](checks/constants-interface.md)
+- [Cyclomatic Complexity](checks/cyclomatic-complexity.md)
+- [CX_ROOT Usage](checks/cx-root-usage.md)
+- [Database Access in Unit-Test](checks/db-access-in-ut.md)
+- [Deprecated Classes](checks/deprecated-classes.md)
+- [Deprecated Key Word](checks/deprecated-key-word.md)
+- [Empty Catch](checks/empty_catch.md)
+- [Empty IF Branches](checks/empty-if-branches.md)
+- [Empty Procedure](checks/empty-procedure.md)
+- [Equals Sign Chaining](checks/equals-sign-chaining.md)
+- [External Call in Unit Test](checks/external-call-in-ut.md)
+- [FORM Routine Usage](checks/form-routine.md)
+- [FUNCTION Module Usage](checks/function-routine.md)
+- [Magic Number Usage](checks/magic-number.md)
+- [Message Easy To Find](checks/message-easy-to-find.md)
+- [Message Translation](checks/message-translation.md)
+- [Method Return Bool](checks/method-return-bool.md)
+- [Missing Interface](checks/interface-in-class.md)
+- [Nesting Depth](checks/maximum-nesting-depth.md)
+- [Non-Class Exception Usage](checks/non-class-exception.md)
+- [Number of Attributes](checks/number-attributes.md)
+- [Number of Events](checks/number-events.md)
+- [Number of Executable Statements](checks/number-executable-statements.md)
+- [Number of Interfaces](checks/number-interfaces.md)
+- [Number of Methods](checks/number-methods.md)
+- [Number of Public Attributes](checks/number-public-attributes.md)
+- [Number of Output Parameter](checks/number-output-parameter.md)
+- [Prefer CASE to ELSEIF](checks/prefer-case-to-elseif.md)
+- [Prefer RETURNING to EXPORTING](checks/prefer-returning-to-exporting.md)
+- [Prefer IS NOT to NOT IS](checks/prefer-is-not-to-not-is.md)
+- [Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT](checks/prefer-line-exists.md)
+- [Prefer NEW to CREATE OBJECT](checks/prefer-new-to-create-object.md)
+- [Prefer Pragmas to Pseudo Comments](checks/prefer-pragmas-to-pseudo-comments.md)
+- [Pseudo Comment Usage](checks/pseudo-comment-usage.md)
+- [Omit Optional EXPORTING](checks/omit-optional-exporting.md)
+- [Optional Parameters](checks/optional-parameters.md)
+- [READ TABLE with Subsequent Memory Assignment](checks/sub-assign-read-table.md)
+- [RECEIVING Statement Usage](checks/receiving-usage.md)
+- [Returning Name](checks/returning-name.md)
+- [Scope of Variable](checks/scope-of-variable.md)
+- [Self-Reference](checks/self-reference.md)
+- [TEST-SEAM Statement Usage](checks/test-seam-usage.md)
+- [Text Assembly](checks/text-assembly.md)
+- [Unit-Test Coverages (Statement, Branch and Procedure)](checks/unit-test-coverages.md)
+- [Unit-Test Assert Validator](checks/unit_test_assert.md)
 
 ## Dependencies
 
-- SAP NetWeaver **7.40 SP8** or higher
+- SAP NetWeaver **7.50** or higher
+- [SAP Note 2527903 - Remote analysis (for check system)](https://launchpad.support.sap.com/#/notes/2527903)
 - [abapGit](https://docs.abapgit.org/)
-- :new: [SAP Note 2527903 - Remote analysis (for check system)](https://launchpad.support.sap.com/#/notes/2527903)
 
 ## How-to Guides
 

abaplint.json

@@ -1,7 +1,7 @@
 {
   "global": {
     "files": "/src/**/*.*",
-    "exclude": ["demo_failures"],
+    "exclude": ["y_code_pal_example"],
     "skipGeneratedGatewayClasses": true,
     "skipGeneratedPersistentClasses": true,
     "skipGeneratedFunctionGroups": true,
@@ -118,7 +118,18 @@
     "no_yoda_conditions": {
       "onlyConstants": true
     },
-    "object_naming": false,
+    "object_naming": {
+      "clas": "^Y(CX|)_(PAL|CODE_PAL)",
+      "intf": "^Y_IF_(PAL|CODE_PAL)",
+      "prog": "^Y_(PAL|CODE_PAL)",
+      "fugr": "^Y_(PAL|CODE_PAL)",
+      "tabl": "^Y(PAL|CODEPAL|TAB)",
+      "ttyp": "^Y_(PAL|CODE_PAL)",
+      "dtel": "^Y(_PAL|_CODE_PAL|CICC)",
+      "doma": "^Y(_PAL|_CODE_PAL|CICC)",
+      "msag": "^Y_(PAL|CODE_PAL)",
+      "tran": "^Y_(PAL|CODE_PAL)"
+    },
     "obsolete_statement": true,
     "omit_parameter_name": true,
     "omit_receiving": true,
@@ -157,13 +168,15 @@
     "type_form_parameters": true,
     "types_naming": false,
     "uncaught_exception": true,
+    "unnecessary_chaining": true,
     "unknown_types": true,
     "unreachable_code": true,
     "unsecure_fae": false,
     "unused_methods": true,
     "unused_types": true,
     "unused_variables": {
-      "severity": "Warning"
+      "severity": "Warning",
+      "skipNames": []
     },
     "use_bool_expression": true,
     "use_class_based_exceptions": true,

changelog.txt

@@ -16,6 +16,13 @@ Legend
 + : added
 - : removed
 
+2021-XX-XX v.1.17.0
+------------------
+* Refactoring Quick Fixes (#523)
++ Quickfix: Pseudo Comment (#509)
++ Check Button: Replicate Configuration
+! Check Button: Edit
+
 2021-11-11 v.1.16.3
 ------------------
 * Incompatibility with abapGit after commit dc4b3705216757c7533f5802d51 (#528)

docs/checks/avoid-default-key.md → docs/avoid-default-key.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Avoid DEFAULT KEY](avoid-default-key.md)
+[code pal for ABAP](../README.md) > [Avoid DEFAULT KEY](avoid-default-key.md)
 
 ## Avoid DEFAULT KEY
 

docs/checks/boolean-input-parameter.md → docs/boolean-input-parameter.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Boolean Input Parameter](boolean-input-parameter.md)
+[code pal for ABAP](../README.md) > [Boolean Input Parameter](boolean-input-parameter.md)
 
 ## Boolean Input Parameter
 

docs/checks/call-method-usage.md → docs/call-method-usage.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [CALL METHOD Usage Check](call-method-usage.md)
+[code pal for ABAP](../README.md) > [CALL METHOD Usage Check](call-method-usage.md)
 
 ## CALL METHOD Usage Check
 

docs/checks/chain-declaration-usage.md → docs/chain-declaration-usage.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Chain Declaration Usage](chain-declaration-usage.md)
+[code pal for ABAP](../README.md) > [Chain Declaration Usage](chain-declaration-usage.md)
 
 ## Chain Declaration Usage
 

docs/checks/check-in-loop.md → docs/check-in-loop.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [CHECK in LOOP](check-in-loop.md)
+[code pal for ABAP](../README.md) > [CHECK in LOOP](check-in-loop.md)
 
 ## CHECK in LOOP
 

docs/checks/check-statement-position.md → docs/check-statement-position.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [CHECK Statement Position Check](check-statement-position.md)
+[code pal for ABAP](../README.md) > [CHECK Statement Position Check](check-statement-position.md)
 
 ## CHECK Statement Position Check
 

docs/checks/collect.md → docs/collect.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [COLLECT restriction](collect.md)
+[code pal for ABAP](../README.md) > [COLLECT restriction](collect.md)
 
 ## COLLECT restriction
 

docs/checks/comment-position.md → docs/comment-position.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Comment Position](comment-position.md)
+[code pal for ABAP](../README.md) > [Comment Position](comment-position.md)
 
 ## Comment Position
 

docs/checks/comment-type.md → docs/comment-type.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Comment Type](comment-type.md)
+[code pal for ABAP](../README.md) > [Comment Type](comment-type.md)
 
 ## Comment Type
 

docs/checks/comment-usage.md → docs/comment-usage.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Comment Usage Check](comment-usage.md)
+[code pal for ABAP](../README.md) > [Comment Usage Check](comment-usage.md)
 
 ## Comment Usage Check
 

docs/checks/constants-interface.md → docs/constants-interface.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Constants Interface Check](constants-interface.md)
+[code pal for ABAP](../README.md) > [Constants Interface Check](constants-interface.md)
 
 ## Constants Interface Check
 

docs/checks/cx-root-usage.md → docs/cx-root-usage.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [CX_ROOT Usage Check](cx-root-usage.md)
+[code pal for ABAP](../README.md) > [CX_ROOT Usage Check](cx-root-usage.md)
 
 ## CX_ROOT Usage Check
 

docs/checks/cyclomatic-complexity.md → docs/cyclomatic-complexity.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Cyclomatic Complexity Check](cyclomatic-complexity.md)
+[code pal for ABAP](../README.md) > [Cyclomatic Complexity Check](cyclomatic-complexity.md)
 
 ## Cyclomatic Complexity Check
 

docs/checks/db-access-in-ut.md → docs/db-access-in-ut.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [DB Access in Unit Tests Check](db-access-in-ut.md)
+[code pal for ABAP](../README.md) > [DB Access in Unit Tests Check](db-access-in-ut.md)
 
 ## Database Access within Unit-Tests Check
 

docs/checks/deprecated-classes.md → docs/deprecated-classes.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Deprecated Classes](deprecated-classes.md)
+[code pal for ABAP](../README.md) > [Deprecated Classes](deprecated-classes.md)
 
 ## Deprecated Classes
 

docs/checks/deprecated-key-word.md → docs/deprecated-key-word.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Deprecated Key Word Check](deprecated-key-word.md)
+[code pal for ABAP](../README.md) > [Deprecated Key Word Check](deprecated-key-word.md)
 
 ## Deprecated Key Word Check
 

docs/checks/empty-catch.md → docs/empty-catch.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Empty Catch](empty_catch.md)
+[code pal for ABAP](../README.md) > [Empty Catch](empty_catch.md)
 
 ## Empty Catch
 

docs/checks/empty-if-branches.md → docs/empty-if-branches.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Empty IF Branches Check](empty-if-branches.md)
+[code pal for ABAP](../README.md) > [Empty IF Branches Check](empty-if-branches.md)
 
 ## Empty IF-Branch Check
 

docs/checks/empty-procedure.md → docs/empty-procedure.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Empty Procedure Check](empty-procedure.md)
+[code pal for ABAP](../README.md) > [Empty Procedure Check](empty-procedure.md)
 
 ## Empty Procedure Check
 

docs/checks/equals-sign-chaining.md → docs/equals-sign-chaining.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Equals Sign Chaining](equals-sign-chaining.md)
+[code pal for ABAP](../README.md) > [Equals Sign Chaining](equals-sign-chaining.md)
 
 ## Equals Sign Chaining
 

docs/checks/external-call-in-ut.md → docs/external-call-in-ut.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [External Call in Unit Tests Check](external-call-in-ut.md)
+[code pal for ABAP](../README.md) > [External Call in Unit Tests Check](external-call-in-ut.md)
 
 ## External Call in Unit Tests-Check
 

docs/checks/form-routine.md → docs/form-routine.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [FORM Routine Check](form-routine.md)
+[code pal for ABAP](../README.md) > [FORM Routine Check](form-routine.md)
 
 ## FORM Routine Usage Check
 

docs/checks/function-routine.md → docs/function-routine.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [FUNCTION Routine Check](function-routine.md)
+[code pal for ABAP](../README.md) > [FUNCTION Routine Check](function-routine.md)
 
 ## FUNCTION Routine Usage Check
 

docs/checks/interface-in-class.md → docs/interface-in-class.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Interface in Class Check](interface-in-class.md)
+[code pal for ABAP](../README.md) > [Interface in Class Check](interface-in-class.md)
 
 ## Interface Missing Check
 

docs/checks/magic-number.md → docs/magic-number.md

@@ -1,4 +1,4 @@
-[code pal for ABAP](../../README.md) > [Documentation](../check_documentation.md) > [Magic Number Check](magic-number.md)
+[code pal for ABAP](../README.md) > [Magic Number Check](magic-number.md)
 
 ## Magic Number Usage Check