Send appname as header on DCL upload #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-blass
requested changes
Aug 15, 2024
pkg/supply/supply.go
Outdated
| UserAgent: fmt.Sprintf("cloud-authorization-buildpack/%s", s.BuildpackVersion), | ||
| ExtraHeaders: map[string]string{ | ||
| "User-Agent": fmt.Sprintf("cloud-authorization-buildpack/%s", s.BuildpackVersion), | ||
| "X-Cf-Appname": vcapApp.ApplicationName, |
There was a problem hiding this comment.
Let's use a more generic name that also fits for other use cases, e.g. if we provide some functionality to upload via CAP or as a k8s job. E.g. just remove the cf part? X-App-Name or X-Appname ?
pkg/supply/env/config.go
Outdated
Comment on lines
24
to
37
| ApplicationID string `json:"application_id"` | ||
| ApplicationName string `json:"application_name"` | ||
| ApplicationUris []string `json:"application_uris"` | ||
| CfAPI string `json:"cf_api"` | ||
| Limits struct { | ||
| Fds int `json:"fds"` | ||
| } `json:"limits"` | ||
| Name string `json:"name"` | ||
| OrganizationID string `json:"organization_id"` | ||
| OrganizationName string `json:"organization_name"` | ||
| SpaceID string `json:"space_id"` | ||
| SpaceName string `json:"space_name"` | ||
| Uris []string `json:"uris"` | ||
| Users any `json:"users"` |
There was a problem hiding this comment.
From what I can see, only the ApplicationName is used in the coding. Let's strip down the struct to what we need exactly, no need to parse the other values.
pkg/supply/env/config.go
Outdated
| Users any `json:"users"` | ||
| } | ||
|
|
||
| func LoadVcapApplication(log *libbuildpack.Logger) (VcapApplication, error) { |
There was a problem hiding this comment.
This func always returns error = nil. Remove error return value?
d047491
force-pushed
the
upload_with_appname
branch
from
3030efe to
1aac254
Compare
|
commited suggested changes |
f-blass
approved these changes
Aug 20, 2024
f-blass
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send appname as header
X-Appnameon dcl-upload